-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bobcat upgrade #268
Bobcat upgrade #268
Conversation
# +++ Chrome +++ | ||
#webdriver.chrome.driver property should point to Chrome webdriver executable. | ||
webdriver.type=chrome | ||
webdriver.chrome.driver=D:/Selenium/chromedriver.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this path is required. Will this work on all instances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right: this is an arbitrary value. If chromedriver is not found then there is a stacktrace with following error:
2) Error in custom provider, java.lang.IllegalStateException: The driver executable does not exist: D:\Selenium\chromedriver.exe
If this config value is commented then we have following error:
2) Error in custom provider, java.lang.IllegalStateException: The path to the driver executable must be set by the webdriver.chrome.driver system property;
What should we do here? Currently on master we have:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should at least document the necessary change on the path to the chromedriver in the comment on in the it-tests README ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have update the README
# Conflicts (resolved): # CHANGELOG.md
Description
Upgrade to newest released version of Bobcat and dependencies clean-up.
Motivation and Context
We should review our functional tests and make them run faster. They might be more compact.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.