Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude-elements doesn't work when taking screenshot of selected page part #379

Closed
tkaik opened this issue Oct 5, 2018 · 0 comments
Closed
Labels

Comments

@tkaik
Copy link
Contributor

tkaik commented Oct 5, 2018

Version used

  • AET 3.0.0

Context of the issue/feature

The exclude-elements feature of the screenshot collector doesn't work correctly when you configure it to take a screenshot of a selected page fragment (using css attribute) and also configure the exclude-elements attribute to exclude some page fragment from screen comparision -- the coordinates of elements to exclude are not computed correctly.

Steps to reproduce

  1. Prepare a suite with screen collector with both css and exclude-elements attribute, e.g. <screen css="#content" exclude-elements=".dynamic1" />.
    The css attribute should point to element which does not start in the top-left corner (i.e. (0; 0) coordinates) of the page body. The exclude-elements attribute should point to element which is inside the element pointed by css attribute and it's displayed differently every time you refresh the page.
  2. Run the suite and open the report - the report shows failure because of differences on element which should have been excluded.
@tkaik tkaik added the bug label Oct 5, 2018
@tkaik tkaik closed this as completed in c9c252b Oct 8, 2018
tkaik added a commit that referenced this issue Oct 8, 2018
…lude

[#379] Exclude elements position calculated with partial screenshot offset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant