Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with placeholder classes in libsass #94

Closed
panec opened this issue Jan 5, 2016 · 1 comment
Closed

Issue with placeholder classes in libsass #94

panec opened this issue Jan 5, 2016 · 1 comment

Comments

@panec
Copy link

panec commented Jan 5, 2016

In the example of the grid with mixins add in the file grid_mixins.scss add this:

.list__item {
    background:#DEDEDE;

    &:nth-child(1) {
        @include gridle(6);
    }
    &:nth-child(2){
        @include gridle(6);
    }
}

This generates the code for the items properly, but for the generic styles that are bundled via _grid_common_grid we receive following selector:

.my-grid-12, .my-grid-6, #site_header,
  #site_footer, #site_content, #site_sidebar, .gallery__item, .list__item:nth-child(1) {

that lacks the selector for the .list__item:nth-child(2).

I was using node-sass@3.4.2 that was fetched by default in your package.

I'm attaching zip with the updated code:
gridle.zip

@olivierbossel
Copy link
Collaborator

Hi,

I've checked your issue on my machine and it seams to be an compiler issue. When I compile with grunt "compass" it's all ok but with grunt sass or gulp sass I got the same issue as you.

%coco {
    content : 'coco';
}
.my-list-item {
    content : 'my list item';

    &:nth-child(1) {
        content : 'coco 1';
        @extend %coco;
    }
    &:nth-child(2) {
        content : 'coco 2';
        @extend %coco;
    }
}

It seems to be an extend issue in the libsass library sass/libsass#1729

For now there's no workaround known sorry.. You will have to find something by yourself until the issue will be fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants