Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile support for the footer in HFG #4185

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Jan 8, 2024

Summary

Allow mobile layout for the Footer Builder in HFG.

Will affect the visual aspect of the product

YES

Screenshots

Footer Desktop/Mobile builder (Pic. 1)

image

Test instructions

  1. On a fresh instance of Neve
  2. Go to "Customizer" > "Footer"
  3. Check that the "Mobile" tab is available for the builder (see Pic. 1)
  4. Check that on the front-end the items from the Desktop are also displayed in Mobile view without changing anything.
  5. Change just one of the views (Mobile or Desktop)
  6. Check on the front-end that each footer is displayed correctly for the view (Mobile/Desktop)
  7. Check that it works as expected with Neve Pro

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2504.

@preda-bogdan preda-bogdan marked this pull request as ready for review January 10, 2024 17:38
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 10, 2024

Plugin build for f1694fe is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 10, 2024
Copy link
Contributor

@GrigoreMihai GrigoreMihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with the code, however there is a test failing that is related to the HFG, I think that is because now we also have the mobile version present same as on this test https://github.com/Codeinwp/neve/pull/4185/files#diff-e6a31b86eae9e18bd070d922c82b1b1ba8ba57166790f571fbd6692d3cb95f10R7?

I will approve it as I think only the test needs to be edited a bit.

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and everything's fine regarding the PR 🚀

@preda-bogdan preda-bogdan merged commit 3595de5 into development Jan 26, 2024
15 checks passed
@preda-bogdan preda-bogdan deleted the feat/mobile_footer_hfg branch January 26, 2024 12:58
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants