Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 7.4 for PHP tests #4170

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 8, 2023

Summary

Use the same PHP version running for Lint and PHPUnit as in PHPStan.

Note

PHPUnit 9 will be used to run the tests.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

Just an update to dev tools. Nothing should be changed in the build.

Check before Pull Request is ready:

Closes #4169

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 8, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 8, 2023 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 8, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 8, 2023 11:13
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 8, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 8, 2023

Plugin build for 46c7582 is ready 🛎️!

Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade all occurrences of 7.1 inside this workflow.

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title chore: use the same PHP version for Lint as in PHPStan chore: use 7.4 for PHP tests Dec 8, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit a10eed8 into development Dec 8, 2023
18 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the chore/php-lint-version branch December 8, 2023 13:23
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV] Update PHP version for PHP CI
4 participants