Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X (Twitter) and Apple Music logo for Social Icons #4152

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 22, 2023

Summary

Added X (Twitter) and Apple Music logo to Social Icons in Customizer.

The icon for Apple Music follows the guidelines: https://marketing.services.apple/apple-music-identity-guidelines

Both SVGs are from official sources.

Note

Neve Pro handles rendering in this PR https://github.com/Codeinwp/neve-pro-addon/pull/2691

Will affect visual aspect of the product

NO

Screenshots

2023-11-22_16-24-09.mp4

image

Test instructions

  • Add Social Icons in Customizer
  • Test the X icon and Apple Music

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2687
Closes https://github.com/Codeinwp/neve-pro-addon/issues/2692

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 22, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 22, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 22, 2023 14:36
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 22, 2023

Plugin build for 44ac870 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 22, 2023
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are also other instance like inside icons.php can you make sure it is updated everywhere?

assets/apps/components/src/Common/icons.js Outdated Show resolved Hide resolved
@Soare-Robert-Daniel
Copy link
Contributor Author

there are also other instance like inside icons.php can you make sure it is updated everywhere?

@preda-bogdan Something like this? https://github.com/Codeinwp/neve-pro-addon/blob/e1c4d57c0bf9c26c4d81e5a56f3de95f8ee6f424/includes/modules/blog_pro/customizer/single_post.php#L188

@preda-bogdan
Copy link
Contributor

@Soare-Robert-Daniel Yes if we are going to update references to Twitter let's make sure it is updated consistently across the board.

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Add X (Twitter) logo for Social Icons Add X (Twitter) and Apple Music logo for Social Icons Nov 23, 2023
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the changes I asked about in my previous review.
Did you check also check the php file for usages of twitter logo?

Please also link the issue that this PR closes on inside the PR body (Closes: #issue_no)

@Soare-Robert-Daniel
Copy link
Contributor Author

I don't see the changes I asked about in my previous review. Did you check also check the php file for usages of twitter logo?

Those are in https://github.com/Codeinwp/neve-pro-addon/pull/2691

To quickly navigate, all of them are linked in the Development section in the Sidebar 👌

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and everything's fine here and in the Neve pro PR 🚀

@preda-bogdan preda-bogdan merged commit f0bb884 into development Jan 26, 2024
16 checks passed
@preda-bogdan preda-bogdan deleted the feat/x-logo branch January 26, 2024 12:55
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants