-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add X (Twitter) and Apple Music logo for Social Icons #4152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are also other instance like inside icons.php
can you make sure it is updated everywhere?
@preda-bogdan Something like this? https://github.com/Codeinwp/neve-pro-addon/blob/e1c4d57c0bf9c26c4d81e5a56f3de95f8ee6f424/includes/modules/blog_pro/customizer/single_post.php#L188 |
@Soare-Robert-Daniel Yes if we are going to update references to Twitter let's make sure it is updated consistently across the board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the changes I asked about in my previous review.
Did you check also check the php file for usages of twitter logo?
Please also link the issue that this PR closes on inside the PR body (Closes: #issue_no)
Those are in https://github.com/Codeinwp/neve-pro-addon/pull/2691 To quickly navigate, all of them are linked in the Development section in the Sidebar 👌 |
@Soare-Robert-Daniel Tested and everything's fine here and in the Neve pro PR 🚀 |
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Added X (Twitter) and Apple Music logo to Social Icons in Customizer.
The icon for Apple Music follows the guidelines: https://marketing.services.apple/apple-music-identity-guidelines
Both SVGs are from official sources.
Note
Neve Pro handles rendering in this PR https://github.com/Codeinwp/neve-pro-addon/pull/2691
Will affect visual aspect of the product
NO
Screenshots
2023-11-22_16-24-09.mp4
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/neve-pro-addon/issues/2687
Closes https://github.com/Codeinwp/neve-pro-addon/issues/2692