Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search icon issues on mobile #4017

Closed
irinelenache opened this issue Jun 28, 2023 · 2 comments · Fixed by #4165 or #4166
Closed

Search icon issues on mobile #4017

irinelenache opened this issue Jun 28, 2023 · 2 comments · Fixed by #4165 or #4166
Assignees
@Soare-Robert-Daniel
Labels
bug This label could be used to identify issues that are caused by a defect in the product. doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@irinelenache
Copy link
Contributor

Description

  • When the search icon is added in the center of the mobile header and the open behaviour is set to minimal, the search bar will appear in its left/right side and will go off screen https://vertis.d.pr/i/UaqtxY
  • The search icon doesn't work when it's added in the mobile sidebar, no matter what open behaviour i'm using (minimal, canvas, float above header) https://vertis.d.pr/v/FS6RPv

Step-by-step reproduction instructions

  1. Add the search icon in the center of the mobile header, set the open behaviour to minimal
  2. Check how the search bar will appear
  3. Add the search icon in the mobile sidebar, with different open behaviours
  4. Try to open it

Screenshots, screen recording, code snippet or Help Scout ticket

Search icon in mobile header - https://vertis.d.pr/i/UaqtxY
Search icon in mobile sidebar - https://vertis.d.pr/v/FS6RPv

Environment info

Wordpress 6.2.2 / Neve 3.6.4

Is the issue you are reporting a regression

No
@irinelenache irinelenache added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 28, 2023
@cristian-ungureanu cristian-ungureanu self-assigned this Aug 2, 2023
@cristian-ungureanu cristian-ungureanu added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Aug 2, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Dec 4, 2023
Merged
6 tasks
This was linked to pull requests Dec 5, 2023
Fix wrong position of search input on minimal when it does not fit in the space. #4165
Merged
Fix the opening of Search Icon in Mobile Sidebar. #4166
Merged
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Dec 6, 2023
Merged
6 tasks
@Soare-Robert-Daniel
Copy link
Contributor

@irinelenache, for the test, test only the newly added PR #4166

@irinelenache irinelenache added the doc-needed This issue requires documentation updates or additions once it has been completed. label Dec 15, 2023
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
bug This label could be used to identify issues that are caused by a defect in the product. doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
5 participants
@cristian-ungureanu @Soare-Robert-Daniel @vytisbulkevicius @pirate-bot @irinelenache