improve mongo legacy check #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that your change breaks MongoDb module on HHVM, please take a look at #3641 and https://github.com/mongofill/mongofill |
|
Good point. I fixed that. |
|
Thanks |
chris1312
pushed a commit
to chris1312/Codeception
that referenced
this pull request
Jun 16, 2017
* improve mongo legacy check * fix wrong result of mongofill library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I think this is a better way for decide wich mongo have to use. If you use both legacy mongo and the current mongodb, the legacy value will be false.
Issue #4174