Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add missing theme tokens #1925

Open
austincondiff opened this issue Oct 28, 2024 · 0 comments
Open

✨ Add missing theme tokens #1925

austincondiff opened this issue Oct 28, 2024 · 0 comments
Labels

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Oct 28, 2024

Description

We currently have "Types" and "Variables" theme tokens. We should replace these two with "Types Declarations", "Type Names", "Variable Declarations", "Variable Names". There are also several more that we might add...

  • classNames
  • typeDeclarations
  • typeNames
  • variableDeclarations
  • variableNames
  • functionDeclarations
  • functionNames
  • propertyNames
  • constants
  • parameterNames
  • moduleNames
  • namespaceNames
  • preprocessorMacros
  • enumMembers
  • annotations

If we added these, the complete token list would look like this...

  • text
  • background
  • insertionPoint
  • lineHighlight
  • selection
  • invisibles
  • keywords
  • classNames
  • types
  • typeDeclarations
  • typeNames
  • attributes
  • commands
  • values
  • constants
  • numbers
  • strings
  • characters
  • variableDeclarations
  • variableNames
  • propertyNames
  • parameterNames
  • functionDeclarations
  • functionNames
  • moduleNames
  • namespaceNames
  • enumMembers
  • preprocessorMacros
  • annotations
  • comments

Additional Context

In Xcode, class names, function names, type names, etc. are differentiated between “Project” and “Other”. This helps developers quickly see what’s part of their project vs. an external dependency, making it easier to navigate complex projects, identify ownership of code, and make refactoring decisions. Is this something we want to implement as well?

We also need to update all of our bundled themes to include these tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant