Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 CodeFileView Reevaluated Every Keystroke #1728

Closed
thecoolwinter opened this issue May 20, 2024 · 0 comments · Fixed by #1740
Closed

🐞 CodeFileView Reevaluated Every Keystroke #1728

thecoolwinter opened this issue May 20, 2024 · 0 comments · Fixed by #1740
Assignees
@thecoolwinter
Labels
bug Something isn't working performance This is performance related source editor workspace

Comments

@thecoolwinter
Copy link
Collaborator

thecoolwinter commented May 20, 2024 •
edited
Loading

Description

CodeFileView is reevaluated each keystroke, causing a severe lag on large files. On top of being reevaluated it does a string compare on CodeFileDocument.content, which causes a hang for large files that then need to be compared character by character.

This issue is a tracking issue for three PRs across CodeEdit, CESourceEditor, and CETextView.

Version Information

CodeEdit: 0.1.0-38
macOS: 14.4
Xcode: 15.3
@thecoolwinter thecoolwinter added bug Something isn't working performance This is performance related workspace source editor labels May 20, 2024
@thecoolwinter thecoolwinter self-assigned this May 20, 2024
@thecoolwinter thecoolwinter moved this from 🆕 New to 🏃‍♂️ In Progress in CodeEdit Project May 20, 2024
This was referenced May 20, 2024
Closed
Merged
@thecoolwinter thecoolwinter mentioned this issue Jun 1, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thecoolwinter thecoolwinter

Labels
bug Something isn't working performance This is performance related source editor workspace
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Single Text Storage For Documents thecoolwinter/CodeEdit
1 participant
@thecoolwinter