🐞 Source editor disappears when deleting all text

[austincondiff]

Description

Deleting all text from the source editor results in the source editor being replaced by a QuickLook view.

To Reproduce

1. Open a project
2. Open a file in the project
3. Delete all of the text in the file
4. Notice the source editor is replaced by a big file icon (QuickLook view)

Expected Behavior

The source editor should remain in place.

Screenshots

Screen.Recording.2024-05-17.at.2.59.54.PM.mov

Related issues

• 🐞 CodeEdit opens most files as blank text files even when a workspace is active #1698
• Correctly preview non-text files #1707

[austincondiff]

@plbstl I believe this was introduced in your recent PR #1707. Would you be able to take a look at this one?

[plbstl]

I see. I'm taking a look at it now

[thecoolwinter]

Whoops, didn't see @plbstl was taking a look. I've got a PR open for this now it was a very small fix.

[plbstl]

Oh okay. I'll also test it out

[plbstl]

I found some issues with #1723.

Doesn't work for:

• files without file extensions
• files with only file extensions

Also, it opens some binaries as text files.

pr-1723.mov

[plbstl]

This is what #1724 looks like:

pr-1724.mov

[FastestMolasses]

Good catch, does this PR replace the other one entirely?

[plbstl]

Yes it does. They are both minor changes.