New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK assumes networkID as tc if not specified. #405

Open

cubismic opened this issue Dec 26, 2019 · 0 comments

Member

cubismic commented Dec 26, 2019 •

edited

Loading

Assuming tc as default networkID is not problem.

But in the first example code of codechain sdk document,
networkID is not specified while constructing SDK object.

This might cause confusion because sdk also assumes networkID as tc in the case below.

var sdk = new SDK({ server: "https://corgi-rpc.codechain.io" });

To set networkId to wc, we should specify it

var sdk = new SDK({ server: "https://corgi-rpc.codechain.io"
 networkId: "wc"});

So I think we should change document or change assuming logic.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment