Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package references to VS2017 syntax #126

Open
shiftkey opened this issue Apr 16, 2017 · 5 comments
Open

update package references to VS2017 syntax #126

shiftkey opened this issue Apr 16, 2017 · 5 comments
Assignees

Comments

@shiftkey
Copy link
Member

There's a bunch of explicit project references from NuGet packages in the current source that can be replaced with PackageReference elements that use the NuGet package name.

An example:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net46</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
    <PackageReference Include="xunit" Version="2.2.0" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
  </ItemGroup>
</Project>

Here's a guide to migrating the project files, which we'd probably need to do to enable this: http://www.natemcmaster.com/blog/2017/03/09/vs2015-to-vs2017-upgrade/

@hnrkndrssn
Copy link
Contributor

I can take this one too 😁

@shiftkey shiftkey assigned shiftkey and hnrkndrssn and unassigned shiftkey Apr 16, 2017
@hnrkndrssn
Copy link
Contributor

So it seems that we might not be able to update the Carnac project to the new VS2017 project format (or perhaps I'm misunderstanding something)...

If you are building WPF, Universal Windows, Xamarin, or ASP.NET 4 projects, you’ll have to stick with the old format

Issue for expanding support to the above project types dotnet/sdk#491

I can start by updating the Carnac.Logic and test project, and then we can upgrade the main project once WPF projects can support the new format.

@shiftkey
Copy link
Member Author

@alfhenrik ugh, there's always a catch. Anyway, have a look and see what we can clean up.

@hnrkndrssn
Copy link
Contributor

This is turning out to be a bit more effort than I first thought so I'm gonna sideline it for a bit while I do #125 as that has more value for our users 😁

@hnrkndrssn
Copy link
Contributor

hnrkndrssn commented May 18, 2017

I'm gonna pick this one up again, we won't be able to update the main WPF project but we should be able to :fingerscrossed: update the other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants