Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which asset are fee's payed with? #95

Closed
MarkoPaasila opened this issue Apr 23, 2018 · 3 comments
Closed

Which asset are fee's payed with? #95

MarkoPaasila opened this issue Apr 23, 2018 · 3 comments
Assignees

Comments

@MarkoPaasila
Copy link
Collaborator

If the account doesn't have any BTS, the fee should be payed with whatever asset is available. Otherwise it will frustrate many new users, especially non-BitShares people. How is this currently handled?

@mikakoi
Copy link
Collaborator

mikakoi commented Apr 23, 2018

It seems that python-bitshares has base for adding transaction fee added in bitshares/python-bitshares#56

But it currently does not support adding fee to buy/sell methods. Those need to first implemented before dexbot can utilize them.

@MarkoPaasila
Copy link
Collaborator Author

Ok let's put this on hold for a while.

@MarkoPaasila
Copy link
Collaborator Author

It was discussed by me and @mikakoi that it would probably be best to contribute the code for paying fee's in any asset to pybitshares, and then make use of it in DEXBot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants