Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod install - error message "Couldn't determine repo name for URL ..." on private repo via SSH #702

Closed
1 task done
glauberl-ciandt opened this issue Sep 2, 2021 · 10 comments · Fixed by #703
Closed
1 task done
Milestone

Comments

@glauberl-ciandt
Copy link

Report

What did you do?

Run pod install

What did you expect to happen?

Install all pod dependencies correctly.

What happened instead?

The error message [!] Couldn't determine repo name for URL: git@ssh.dev.azure.com:v3/aa-aaaaa/aaa_aaa_aaaaa/aaa-aaa-aaaaa has been displayed.

CocoaPods Environment

Stack

   CocoaPods : 1.11.0
        Ruby : ruby 2.7.3p183 (2021-04-05 revision 6847ee089d) [x86_64-darwin20]
    RubyGems : 3.1.6
        Host : macOS 11.5.2 (20G95)
       Xcode : 12.5.1 (12E507)
         Git : git version 2.30.1 (Apple Git-130)
Ruby lib dir : /Users/glauberl/.rbenv/versions/2.7.3/lib
Repositories : 

Installation Source

Executable Path: /Users/glauberl/.rbenv/versions/2.7.3/bin/pod

Plugins

cocoapods-deintegrate : 1.0.5
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.1
cocoapods-trunk       : 1.6.0
cocoapods-try         : 1.2.0

Podfile

platform :ios, '12'
use_frameworks!

source 'git@ssh.dev.azure.com:v3/company/project/repository'
source 'https://github.com/CocoaPods/Specs.git'

def shared_dependencies
	pod 'DependencyA', git: 'git@ssh.dev.azure.com:v3/company/project/repository', tag: '0.0.50'
	pod 'DependencyB', '~>0.2.0'
	pod 'DependencyC'
	pod 'DependencyD', '~>3.3.1'
	pod 'DependencyE'
	pod 'DependencyAF', '~>0.0.68'
	pod 'DependencyG', '~>0.1.2'
end

target 'pdp' do
	shared_dependencies

  target 'pdpTests' do
		inherit! :search_paths
    pod 'DependencyH', '~>0.2.0'
  end
end

target 'pdpDemo' do
	shared_dependencies

  target 'pdpDemoTests' do
		inherit! :search_paths
  end
  
  target 'pdpDemoUITests' do
		inherit! :complete
    pod 'DependencyI', '~>0.2.0'
  end
end

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12'
            config.build_settings['ONLY_ACTIVE_ARCH'] = 'NO'
            config.build_settings['ENABLE_BITCODE'] = 'NO'
            config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ''
            config.build_settings['CODE_SIGNING_REQUIRED'] = 'NO'
            config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
    end
end

Notes

  • It's a private repository hosted on Microsoft Azure, cannot share it here. Had to mask the real names.
  • Noticed the issue right after updated from CocoaPods 1.10.2 to 11.1.
  • It's only happening when the source is SSH, HTTPS is fine.
@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

cc @igor-makarov maybe related to some Core changes?

@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

Most likely related to #681

@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

@glauberl-ciandt if you can expand to fix the regex in #681 with a test it will be very easy to ship 1.11.1 for us.

Sorry for this regression.

@glauberl-ciandt
Copy link
Author

glauberl-ciandt commented Sep 2, 2021

@glauberl-ciandt if you can expand to fix the regex in CocoaPods/Core#681 with a test it will be very easy to ship 1.11.1 for us.

Sorry for this regression.

Done. I updated the error message using aaa's for a-z pattern and the rest remained the same.

Let me know if you need further information.

@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

no need! Some help to open the PR if you want to fix it would be great :)

@glauberl-ciandt
Copy link
Author

no need! Some help to open the PR if you want to fix it would be great :)

I'll do my best. First time opening a PR to CocoaPods repo! Let's see how it goes.

Just to confirm: the regex is what needs to be fixed, right? Or needs further investigation?

@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

I am fairly certain its the regex. It will be a PR on this repo https://github.com/CocoaPods/Core

See this PR #681 of the files to change.

Add a test first and run bundle exec bacon <path_to_file_spec.rb> to run and see it failing. Then update the regex and re-run to make it pass.

@dnkoutso dnkoutso transferred this issue from CocoaPods/CocoaPods Sep 2, 2021
@dnkoutso dnkoutso added this to the 1.11.1 milestone Sep 2, 2021
@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

@glauberl-ciandt I put a PR up #703 will wait for some review/feedback to land it.

@dnkoutso
Copy link
Contributor

dnkoutso commented Sep 2, 2021

fixed with #703

@glauberlima
Copy link

Cool! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants