Set SKIP_INSTALL=YES for all generated targets

[mrackwitz]

Fixes #3007.

[segiddins]

Is there a chance this will have unintended side effects when using Pods in a framework, or something?

[mrackwitz]

This could influence every build script, which rely on the build paths of generated build products.
If SKIP_INSTALL=YES and DEPLOYMENT_LOCATION=YES, which is implied by ACTION=install, which is the verb given on the CLI to xcodebuild, then the build product is placed into $TARGET_TEMP_DIR/UninstalledProducts.
Usually, this happens for a framework or library target only when the target is build as an implicit target dependency of an app target, which the user archives from Xcode.
This does not apply for cocoapods-packager.

[segiddins]

@mrackwitz I'm not sure you've answered my question, which is, will this break things when you use CocoaPods with a framework target?

[mrackwitz]

It could because the AggregateXCConfig is shared with the user target.
But it's only a matter if the user actually want to install the framework to the system's framework paths ($(LOCAL_LIBRARY_DIR)/Frameworks) or use INSTALL_PATH in a different way, which applies probably only in rare cases.
We could avoid that by inlining the build setting to Pods.xcodeproj.

[segiddins]

So are you saying I shouldn't merge this PR now?

[segiddins]

two spaces

[segiddins]

@kylef I'll merge if this gets your 👍