Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fb/add command labels in tcp connect metrics and span attributes #260

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Fb/add command labels in tcp connect metrics and span attributes #260

merged 6 commits into from
Jun 23, 2022

Conversation

NeJan2020
Copy link
Collaborator

linked #259

NeJan2020 added 3 commits June 21, 2022 17:56
@NeJan2020
feat: add command info in tcp_connect metrics
413a13e 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020
feat: add pid and command info in trace
7e72dec 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020
doc: add comm descrition in doc
773171a 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020 NeJan2020 requested a review from dxsup June 21, 2022 10:15
NeJan2020 added 3 commits June 21, 2022 19:11
@NeJan2020
doc: update config
8395405 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020
fix: add command info in connectionStats
1bc01e8 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020
fix: add comm in aggreagation Selectors
842fa6f 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
dxsup
dxsup approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@dxsup dxsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dxsup dxsup merged commit f8cd235 into KindlingProject:main Jun 23, 2022
@dxsup dxsup mentioned this pull request Jun 24, 2022
Closed
@NeJan2020 NeJan2020 deleted the fb/add_comm_labels_in_tcp_connect_metrics_and_span branch June 28, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dxsup dxsup dxsup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeJan2020 @dxsup