Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:fix language issues in document #258

Merged
merged 3 commits into from
Jun 22, 2022
Merged

docs:fix language issues in document #258

merged 3 commits into from
Jun 22, 2022

Conversation

blue-troy
Copy link
Contributor

Signed-off-by: blue-troy 12729455+blue-troy@users.noreply.github.com

fix language issues in document

Description

fix language issues in document,such as active spelled as ative

Related Issue

link #257

Motivation and Context

How Has This Been Tested?

Signed-off-by: blue-troy <12729455+blue-troy@users.noreply.github.com>
@dxsup
Copy link
Member

dxsup commented Jun 21, 2022

Welcome to the kindling community and thanks for your contribution. I found that there are still some other issues in these documents. Would you mind if I corrected those in this PR? Or I will open another PR after merging yours.

@blue-troy
Copy link
Contributor Author

Welcome to the kindling community and thanks for your contribution. I found that there are still some other issues in these documents. Would you mind if I corrected those in this PR? Or I will open another PR after merging yours.

does other issues language problem?

@dxsup
Copy link
Member

dxsup commented Jun 21, 2022

Yes. Some examples in CONTRIBUTING.md are as follows.

Thank you for you(-> [your]) interest in contributing to kindling!

you(-> [You]) can contribute to Kindling in several ways,(->[, ])like:

l(-> [-]) Contribute to the codebase
l(-> [-]) Report and triage bugs
l(-> [-]) Write technical documentation and blog posts, for users and contributors
l(-> [-]) Help others by answering questions about Kindling

Report a bug by submitting a new issue. Make sure follow(-> [to follow]) the issue template and add more detail(-> [detailed]) informations(-> [information]) that will help us replicate the problem.

I can help correct these issues in this PR if you don't mind.

@blue-troy
Copy link
Contributor Author

Yes. Some examples in CONTRIBUTING.md are as follows.

Thank you for you(-> [your]) interest in contributing to kindling!

you(-> [You]) can contribute to Kindling in several ways,(->[, ])like:

l(-> [-]) Contribute to the codebase
l(-> [-]) Report and triage bugs
l(-> [-]) Write technical documentation and blog posts, for users and contributors
l(-> [-]) Help others by answering questions about Kindling

Report a bug by submitting a new issue. Make sure follow(-> [to follow]) the issue template and add more detail(-> [detailed]) informations(-> [information]) that will help us replicate the problem.

I can help correct these issues in this PR if you don't mind.

OK

Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
@dxsup dxsup requested review from dxsup and J-lena June 22, 2022 03:15
@dxsup
Copy link
Member

dxsup commented Jun 22, 2022

@blue-troy
I have corrected other issues found in the docs. Please take a look and we'll merge this PR after receiving your response.

change Github to GitHub

Signed-off-by: blue-troy <12729455+blue-troy@users.noreply.github.com>
@blue-troy
Copy link
Contributor Author

@blue-troy I have corrected other issues found in the docs. Please take a look and we'll merge this PR after receiving your response.

OK,and i change Github to GitHub

@dxsup dxsup merged commit bd2a843 into KindlingProject:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants