Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the onUpdate and delete method of pod #245

Merged
merged 7 commits into from
Jun 13, 2022
Merged

Rewrite the onUpdate and delete method of pod #245

merged 7 commits into from
Jun 13, 2022

Conversation

dxsup
Copy link
Member

@dxsup dxsup commented Jun 10, 2022

Description

  1. Replace PodInfo with k8sPodInfo in the globalPodInfo. This helps reduce the complexity of the data structure of pods.
  2. Only delete the desired fields of pods when delayed deleting.
  3. Rewrite the onUpdate method to avoid the delayed deleting requests removing everything.

Related Issue

#239

How Has This Been Tested?

Now the test case that failed before is passed.

=== RUN   TestUpdateDelayDelete
    pod_watch_test.go:218: Found container [192.168.136.210:9001]
    pod_watch_test.go:228: Found container [192.168.136.210:9001]
--- PASS: TestUpdateDelayDelete (0.61s)
PASS

Daxin Wang added 4 commits June 9, 2022 16:15
add testcase to reproduce the bug
7a4137d 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
replace PodInfo with k8sPodInfo at the globalPodInfo
ad16fbf 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
record which part of pod should be deleted in the cache
18547da 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
fix onUpdate bug
aca2955 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
@dxsup dxsup requested a review from NeJan2020 June 10, 2022 04:11
@NeJan2020
test: update TestUpdateAndDelayDelete TestCase
6dda9ed 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
@NeJan2020
fix: remove all old IpPortInfo if PodIp changed
cf489a5 
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
NeJan2020
NeJan2020 previously approved these changes Jun 13, 2022
View reviewed changes
fix typo
7cb2d32 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
@dxsup dxsup merged commit b626a2d into KindlingProject:main Jun 13, 2022
@dxsup dxsup deleted the fix/pod-update-delete-info branch June 13, 2022 02:34
@dxsup dxsup mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeJan2020 NeJan2020 NeJan2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxsup @NeJan2020