Search for k8s metadata using src_ip when no containerid found #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
approved these changes
Jun 1, 2022
Comment on lines
+100
to
+104
| srcIp := labelMap.GetStringValue(constlabels.SrcIp) | ||
| if srcIp == loopbackIp { | ||
| labelMap.UpdateAddStringValue(constlabels.SrcNodeIp, p.localNodeIp) | ||
| labelMap.UpdateAddStringValue(constlabels.SrcNode, p.localNodeName) | ||
| } |
There was a problem hiding this comment.
LGTM, Although The k8s information searched may be incorrect when processing data from the loopback device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Search for k8s metadata using
src_ipwhen nocontainer_idis found.Motivation and Context
We have found that the event from the client-side doesn't contain the container id in a very small possibility, in which case we take the src_ip as the key to find its k8s metadata.