Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the kindling-collector-config.yml caused by "stat ~/.kube/config: no such file or directory" #225

Merged
merged 2 commits into from
May 17, 2022

Conversation

yaofighting
Copy link
Contributor

Signed-off-by: yaofighting siyao@zju.edu.cn

fix the collector config and make it running normally on the Linux environment

Description

in the file /root/kindling/collector/docker/kindling-collector-config.yml, we can see a bug about that we may not boot the collector normally in the Linux environment due to the "kube_config_dir" is "~" instead of "root", so in this PR, I fix it.

Related Issue

#224

Motivation and Context

it fix the compatibility of collector

How Has This Been Tested?

just compile and build the collector container with the doc's step.

@yaofighting yaofighting changed the title fix the collector config fix the kindling-collector-config.yml caused by "stat ~/.kube/config: no such file or directory" May 16, 2022
Copy link
Member

@dxsup dxsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another configuration file under the directory kindling/deploy. Although it is using serviceaccount as its kube_auth_type and kube_config_dir isn't effective, I think we better make this field same to avoid misunderstanding.

collector/docker/kindling-collector-config.yml Outdated Show resolved Hide resolved
Signed-off-by: yaofighting <siyao@zju.edu.cn>
Copy link
Member

@dxsup dxsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yaofighting <siyao@zju.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants