Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color scheme & visuals improvement #8

Closed
3 tasks done
Tracked by #1
CloneWith opened this issue Jul 29, 2024 · 3 comments
Closed
3 tasks done
Tracked by #1

Color scheme & visuals improvement #8

CloneWith opened this issue Jul 29, 2024 · 3 comments

Comments

@CloneWith
Copy link
Owner

CloneWith commented Jul 29, 2024

Redesign the colour scheme (or visual style) of win, pick and ban to make them more distinguishable.


Some changes must be done before we merge this branch into two currently active branches derived/tboard and derived/tboard_ntcsAppend:

  • Trap icons has to be coloured
  • Background colour change implementation method (Highest priority)
  • Remove trophy icons from winning boxes (won't implement)
@CloneWith CloneWith mentioned this issue Jul 29, 2024
19 tasks
@CloneWith CloneWith changed the title Redesign colour scheme (or visual style) of win, pick and ban to make them more distinguishable. Color scheme improvement Jul 29, 2024
@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 30, 2024

commit d69115b on branch derived/tboard_ntcsAppend changed visual style for box actions. Visuals are not in its final state so further adjustment is required.

                    case ChoiceType.RedWin:
                        Alpha = 1f;
                        icon.Icon = FontAwesome.Solid.Trophy;
                        icon.Colour = new OsuColour().Red;
                        icon.Alpha = 0.73f; // Added this line to distinguish last win from other wins
                        break;

                    case ChoiceType.BlueWin:
                        Alpha = 1f;
                        icon.Icon = FontAwesome.Solid.Trophy;
                        icon.Colour = new OsuColour().Blue;
                        icon.Alpha = 0.73f; // Added this line to distinguish last win from other wins
                        break;

Used icon.Alpha = <value>; to distinguish last win from other wins. Last win will be completely non-transparent while other wins display with a certain transparency:

image


I also adjusted the "flashing" effect, as the modified flashing effect seems to be too subtle:

                if (shouldFlash)
                {
                    flash.FadeOutFromOne(900).Loop(0, 3);
                    icon.FadeInFromZero(500);
                }

Now boxes will flash at a slow speed for 3 times, which I believe is a balance point between the original and modified flashing effect. Suggestions welcome.


After talking to the art & design team, they said that now only Trap has to change its visual, others are in a good state now.

@NaughtyChas NaughtyChas changed the title Color scheme improvement Color scheme & visuals improvement Jul 30, 2024
@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Aug 5, 2024

Newer design of these boxes had already been pushed onto branch feature/BoardColor. Some changes must be done before we merge this branch into two currently active branches derived/tboard and derived/tboard_ntcsAppend:


  1. Trap icons has to be coloured.

Current design of the trap display is truely indistinguishable for red and blue:

Left indicates Red Trap, vice versa.

Art & Design Team has suggested to change the visual style into:

  • Use white boundary colour
  • Use Coloured trap icon

Just like what we did for protect buttons, but the box boundary will not be coloured.

Should be better in display when picked / win status have added to this box.


  1. Background colour change implementation method

This should be in the 1st priority, since a protect box had a winning status added to it, the colour of the lock icon will be altered, leading more distinguishability issues.

Red protect Red win / Blue protect Blue win Red protect Blue win / Blue protect Red win
image image

Two viable options to address this problem:

  • Reshape the code to let the icons appear to be "above the colour filter layer".
  • Change the background image to work as colour filter instead.
    • If we have chosen to go with this, we might have to take the text colour into account.

  1. Remove trophy icons from winning boxes

Can't be more straight forward than that.


Should be something I have missed or fogotten, Add more bulletpoints below if you got more.

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Aug 7, 2024

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants