-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRC chat display in Board scene #5
Comments
Further information required for "Validation". Pinging @CloneWith |
Maybe worth considering to add this visual style for better looking. |
Since I didnt have a channel to display in the Chat section, it might be good to let you have a look at the changes. If everything seems okay then we could safely check this off the list. |
Just added a round corner of 10(px?) in the latest commit, and accidentally pushed to your branch ;w; |
Reviewed. |
latest version of osu!(lazer) in release 2024.731.0 has changed the visual for chat boxes: Careful when syncing main branch if we don't want this new visual style. [Edited] Confirm on using the legacy chatbox design. DO NOT sync main branch or we have to find a fix to address this. |
thx for noticing me about this! Our group definitely won't want this I think. I'll try to find out if there is a reachable variable controlling this behaviour. |
Fortunately the contributor kindly used a public struct, enabling us to simply change this argument on message line definition: protected partial class MatchMessage : StandAloneMessage
{
public MatchMessage(Message message, LadderInfo info)
: base(message)
{
// Disable alternating background
AlternatingBackground = false;
if (info.CurrentMatch.Value is TournamentMatch match)
{
if (match.Team1.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
UsernameColour = TournamentGame.COLOUR_RED;
else if (match.Team2.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
UsernameColour = TournamentGame.COLOUR_BLUE;
}
}
} I'll update our branch and try this patch. |
In commit 47feaad I have disabled that
Chat timestamps are displayed differently. Waiting feedback from other groupmembers... |
Have implemented a simple layout with the Chat display at the left side of the Board.
Further work needs to be done to:
The text was updated successfully, but these errors were encountered: