Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRC chat display in Board scene #5

Closed
5 tasks done
Tracked by #1
CloneWith opened this issue Jul 29, 2024 · 11 comments
Closed
5 tasks done
Tracked by #1

Add IRC chat display in Board scene #5

CloneWith opened this issue Jul 29, 2024 · 11 comments
Labels
area:Board priority:1 question Further information is requested

Comments

@CloneWith
Copy link
Owner

CloneWith commented Jul 29, 2024

Have implemented a simple layout with the Chat display at the left side of the Board.

Further work needs to be done to:

  • Add IRC chat display in board scene
  • Move the round title somewhere else
  • Validation
  • Add rounded corner visual style for IRC chat board. (Appended)
  • Revert chatbox visual style
@CloneWith CloneWith mentioned this issue Jul 29, 2024
19 tasks
@CloneWith CloneWith changed the title Add irc chat display in board scene. Add IRC chat display in Board scene Jul 29, 2024
@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 29, 2024

  • Validation

Further information required for "Validation". Pinging @CloneWith

@NaughtyChas NaughtyChas added the question Further information is requested label Jul 29, 2024
@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 29, 2024

  • Add rounded corner visual style for IRC chat board. (Appended)

Maybe worth considering to add this visual style for better looking.

@CloneWith
Copy link
Owner Author

Further information required for "Validation".

Since I didnt have a channel to display in the Chat section, it might be good to let you have a look at the changes. If everything seems okay then we could safely check this off the list.

@NaughtyChas
Copy link
Collaborator

Further information required for "Validation".

Since I didnt have a channel to display in the Chat section, it might be good to let you have a look at the changes. If everything seems okay then we could safely check this off the list.

Chatbox is working as expected, checked this off:

image

@CloneWith
Copy link
Owner Author

Maybe worth considering to add this visual style for better looking.

Just added a round corner of 10(px?) in the latest commit, and accidentally pushed to your branch ;w;
Anyway you can try it at your side...

@NaughtyChas
Copy link
Collaborator

Maybe worth considering to add this visual style for better looking.

Just added a round corner of 10(px?) in the latest commit, and accidentally pushed to your branch ;w; Anyway you can try it at your side...

Reviewed.

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 31, 2024

  • Move the round title somewhere else

See commit 72f4385.

We have to use the same chatbox layout in EX Scene, more about this will be traced in a new issue #4 .

@NaughtyChas NaughtyChas changed the title Add IRC chat display in Board scene New board scene layout Aug 1, 2024
@NaughtyChas NaughtyChas mentioned this issue Aug 1, 2024
3 tasks
@NaughtyChas NaughtyChas changed the title New board scene layout Add IRC chat display in Board scene Aug 1, 2024
@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Aug 1, 2024

latest version of osu!(lazer) in release 2024.731.0 has changed the visual for chat boxes:

image

Careful when syncing main branch if we don't want this new visual style.


[Edited]

Confirm on using the legacy chatbox design. DO NOT sync main branch or we have to find a fix to address this.

@CloneWith
Copy link
Owner Author

Careful when syncing main branch if we don't want this new visual style.

thx for noticing me about this!

Our group definitely won't want this I think.

I'll try to find out if there is a reachable variable controlling this behaviour.

@CloneWith
Copy link
Owner Author

CloneWith commented Aug 1, 2024

I'll try to find out if there is a reachable variable controlling this behaviour.

Fortunately the contributor kindly used a public struct, enabling us to simply change this argument on message line definition:

        protected partial class MatchMessage : StandAloneMessage
        {
            public MatchMessage(Message message, LadderInfo info)
                : base(message)
            {
                // Disable alternating background
                AlternatingBackground = false;

                if (info.CurrentMatch.Value is TournamentMatch match)
                {
                    if (match.Team1.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
                        UsernameColour = TournamentGame.COLOUR_RED;
                    else if (match.Team2.Value?.Players.Any(u => u.OnlineID == Message.Sender.OnlineID) == true)
                        UsernameColour = TournamentGame.COLOUR_BLUE;
                }
            }
        }

I'll update our branch and try this patch.

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Aug 3, 2024

In commit 47feaad I have disabled that AlternatingBackground effect for chatboxes. Apart from that, some details are worth notice:

Before release 2024.731.0 After release 2024.731.0
image image

Chat timestamps are displayed differently. Waiting feedback from other groupmembers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Board priority:1 question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants