Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toolkit widget usage #3

Open
CloneWith opened this issue Jul 29, 2024 · 6 comments
Open

Refactor toolkit widget usage #3

CloneWith opened this issue Jul 29, 2024 · 6 comments

Comments

@CloneWith
Copy link
Owner

CloneWith commented Jul 29, 2024

We should use a proper type of widget for each action.
For example, we should use toggles instead of buttons for Chat display status to avoid ambiguity.

@CloneWith CloneWith mentioned this issue Jul 29, 2024
19 tasks
@CloneWith CloneWith changed the title Use correct toggle buttons for toggle actions. (e.g. Toggle chat) Refactor toolkit widget usage Jul 29, 2024
@NaughtyChas
Copy link
Collaborator

Commit dbc7171 revert changes in Gameplay scene, pushed onto branch derived/tboard in commit 5c99492:

image

since Toggle Chat won't work when there is a ongoing gameplay, toggling that toggler will causing a issue where the status of the toggler is not being synced with the status of the chatbox.

@CloneWith
Copy link
Owner Author

CloneWith commented Jul 31, 2024

Commit dbc7171 revert changes in Gameplay scene, pushed onto branch derived/tboard in commit 5c99492:

Unfortunately, it's not working at all ;w;
I'll try to fix this.


've pushed a commit to your branch, attempting to fix the problem.
If there is still something broken please reply below.

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 31, 2024

Commit dbc7171 revert changes in Gameplay scene, pushed onto branch derived/tboard in commit 5c99492:

Unfortunately, it's not working at all ;w; I'll try to fix this.

This Toggle Chat is rarely used in practice, since lazer tourney will automatically handles the chatbox display:

  • When there is no ongoing match, no score will be displayed, chatbox will be displayed at bottom left of the screen.
  • When there is an ongoing match, scores will be displayed, beatmap information will be displayed instead.

Might be better to understand these with a tournament footage.

There is a good chance which the Toggle Chat button is already bugged.

@NaughtyChas
Copy link
Collaborator

've pushed a commit to your branch, attempting to fix the problem. If there is still something broken please reply below.

Everything's looking good.

@cdwcgt cdwcgt closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@CloneWith
Copy link
Owner Author

Have recently found out that we can do further on this:

  • Component display text and tooltips
  • Right type of widgets throughout the tournament client and, even osu!lazer

@CloneWith
Copy link
Owner Author

Due to a planned UI refactor in OFFC S2 iteration, this is migrated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

3 participants