Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User current rank / PP does not display correctly #15

Closed
Tracked by #1
NaughtyChas opened this issue Aug 2, 2024 · 2 comments
Closed
Tracked by #1

User current rank / PP does not display correctly #15

NaughtyChas opened this issue Aug 2, 2024 · 2 comments
Labels
area:Components bug Something isn't working help wanted Extra attention is needed priority:1 size:Small

Comments

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Aug 2, 2024

Found in the development process of issue #14 .

@NaughtyChas
Copy link
Collaborator Author

NaughtyChas commented Aug 2, 2024

The displayed global rank does not match current value:

on website in tourney (board scene) rank 2 days ago
image image image

The value only matches the rank 2-5 days ago.

Layout and code defined at osu.Game.Tournament/Components/TeamPlayerCard.cs, at line 81-107, on branch derived/tboard_ntcsAppend:

We use teamPlayer?.Statistics.GlobalRank to gather rank, which the value is incorrect.


Same for PP, at at line 81-107, we use teamPlayer?.Statistics.PP which return nothing.

To see its original effect on rank + PP display, head into Team Editor section, defined at line 52-62 in file osu.Game/Users/UserListPanel.cs:

string performance = User.Statistics?.PP?.ToString("N0") ?? "-"; is used to assign PP value gathered into performance. As no value is being gathered, - is always being displayed on the panel:

image


Help wanted, as we are wondering if we have used the wrong API, or other parts of the code went wrong. Pinging for @cdwcgt for help.

@NaughtyChas
Copy link
Collaborator Author

Resolved by @cdwcgt in commit 6d9fe12 on branch derived/tboard_cdwcgtAppend:

image

Huge thanks from the team!

@NaughtyChas NaughtyChas mentioned this issue Aug 5, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Components bug Something isn't working help wanted Extra attention is needed priority:1 size:Small
Projects
None yet
Development

No branches or pull requests

1 participant