Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign new style of mappool card #11

Closed
2 of 3 tasks
Tracked by #1
NaughtyChas opened this issue Jul 30, 2024 · 9 comments · Fixed by #45
Closed
2 of 3 tasks
Tracked by #1

Redesign new style of mappool card #11

NaughtyChas opened this issue Jul 30, 2024 · 9 comments · Fixed by #45
Assignees
Labels
area:Components area:Mappool area:Tournament Things about the tournament client iteration:S1 Cirno priority:1 size:Large target:lazer Changes exporting to upstream target:OFFC FumoFumo specific features

Comments

@NaughtyChas
Copy link
Collaborator

NaughtyChas commented Jul 30, 2024

大家好啊,我是说的道理。今天来点大家想看的评论啊。

  • Basic layout implementation
  • Animation and interaction
  • Tests
@NaughtyChas
Copy link
Collaborator Author

Mappool scene will not be used during OFFC tournament, add this feature if wanted. Lowering down priority to level 3.

@NaughtyChas
Copy link
Collaborator Author

NaughtyChas commented Aug 7, 2024

Mappool scene is currently not in a fine state, as we have went too far on the Board scene, something went broke in the visuals of the mappool scene. Also there is no requirement for OFFC to use the mappool screen, so the entry of the mappool screen might get removed in the future.

Since we have no requirements to support this feature in the code at this stage, closing this issue now.

@NaughtyChas NaughtyChas closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@CloneWith
Copy link
Owner

CloneWith commented Sep 28, 2024

As a goal in the long term, decided to reopen this and plan for this week.

At least it's suggested to adjust the style of the blocks with different states (protected, trapped, etc.), since the initial design for these is a bit odd.

@CloneWith CloneWith reopened this Sep 28, 2024
@NaughtyChas
Copy link
Collaborator Author

Might be useful to provide a quick reference to protection visual in osu!mania 4K match, MWC4K:

image

I reckon putting the icon on the right side might be a better choice, or, we design a brand new visual scheme, more about this can be progressed on figma, depending on your decision.

@CloneWith
Copy link
Owner

Might be useful to provide a quick reference to protection visual in osu!mania 4K match, MWC4K:

image

I reckon putting the icon on the right side might be a better choice, or, we design a brand new visual scheme, more about this can be progressed on figma, depending on your decision.

I'm pretty into this. Would you work on this further? Can redesign this with tool (Figma, or 即时设计 more generally used here) assisted when possible.

@NaughtyChas
Copy link
Collaborator Author

Might be useful to provide a quick reference to protection visual in osu!mania 4K match, MWC4K:
image
I reckon putting the icon on the right side might be a better choice, or, we design a brand new visual scheme, more about this can be progressed on figma, depending on your decision.

I'm pretty into this. Would you work on this further? Can redesign this with tool (Figma, or 即时设计 more generally used here) assisted when possible.

Not sure if Figma is accessible and running stable under Mainland China network?

@NaughtyChas
Copy link
Collaborator Author

NaughtyChas commented Oct 15, 2024

@CloneWith

I've come up with a new set of design of the mappool scene components. Majority of the assets are from osu! official figma design library,so it should be looking good when fitting into lazer interface.

https://www.figma.com/design/W5gXDLnX0ZbkTRNZSW9iAy/Mappool-design?m=auto&t=TklghI1kCb8Z6Jzo-1

Only components design are being displayed. More stuff (animation design, detail polishing) will get updated later.

@CloneWith
Copy link
Owner

Just've listed some critical tasks for tracking, written above.
Happy coding!

@CloneWith CloneWith self-assigned this Oct 15, 2024
@CloneWith CloneWith added priority:1 size:Large area:Components area:Tournament Things about the tournament client target:OFFC FumoFumo specific features target:lazer Changes exporting to upstream and removed priority:3 labels Oct 15, 2024
@CloneWith CloneWith changed the title Add "protect" option and visual for mappool scene Redesign new style of mappool card Oct 15, 2024
@NaughtyChas
Copy link
Collaborator Author

NaughtyChas commented Oct 21, 2024

Nah bro we didn't finish the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Components area:Mappool area:Tournament Things about the tournament client iteration:S1 Cirno priority:1 size:Large target:lazer Changes exporting to upstream target:OFFC FumoFumo specific features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants