Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Reverse chronological resource ordering #130

Closed
VeckoTheGecko opened this issue May 8, 2023 · 2 comments · Fixed by #135
Closed

[FEATURE] Reverse chronological resource ordering #130

VeckoTheGecko opened this issue May 8, 2023 · 2 comments · Fixed by #135
Labels
coding Change that requires coding enhancement New feature or request for the website good first issue Good for new developers help wanted Extra attention is needed 🟠medium priority A medium priority feature

Comments

@VeckoTheGecko
Copy link
Collaborator

VeckoTheGecko commented May 8, 2023

Describe your suggested improvement
Currently the order of the resource list in the website mirrors the resource list in data/resources.yml (i.e. resources are added to the bottom of the .yml file and also displayed at the bottom of the website.

Reversing this (so newer resources appear at the top of the website) would allow people to quickly check back to the site and see if new resources have been added.

Describe the benefit
Highlights the dynamic nature of the site, and rewards users who visit regularly with the new resources they're looking for.

Would you be capable/willing to implement the improvement?
Good first issue for someone wanting to get involved. If nobody claims it, will make a PR for it this weekend.

Other comments

Data is loaded in here. yml_data is a list of objects (as represented in the YAML file.

// Reading in resources
const file = fs.readFileSync(resources_path, 'utf8')
const yml_data = parse(file) // TODO: Create interface for this, and then use it to validate edits during CI/CD

@VeckoTheGecko VeckoTheGecko added enhancement New feature or request for the website good first issue Good for new developers help wanted Extra attention is needed coding Change that requires coding 🟠medium priority A medium priority feature labels May 8, 2023
@Micahg05
Copy link
Contributor

Micahg05 commented May 8, 2023

Ill do this real quick. Good warmup for the PR process and building the project.

@Micahg05
Copy link
Contributor

Micahg05 commented May 8, 2023

@VeckoTheGecko since the data doesn't contain a time to key off of newest vs oldest items is the ongoing assumption going to be that its always just a reverse order of the array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding Change that requires coding enhancement New feature or request for the website good first issue Good for new developers help wanted Extra attention is needed 🟠medium priority A medium priority feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants