Allow dropping partitions with Date type column #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you like to supply a unit test as well? |
|
@pan3793 is unit test mandatory? Seems it would take more efforts. |
|
OK, looks pretty safe, merged. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the
DROP PARTITIONoperation to work with tables that have a column of type Date as partition. With this change, you can use a statement like the following to drop a partition from a ClickHouse table:where dt is a column with type Date. Before this change, attempting to drop a partition with a Date column would result in an error.
I've tested this change by running the
DROP PARTITIONoperation on a table with a Date column, and I've verified that it works as expected.Let me know if you have any questions or concerns about this change.