-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark: Add column comment when create clickhouse table #176
Conversation
Thanks, LGTM, would you please make this change in spark-3.3 as well? And better to add a unit test for verification(encouraged but not mandatory) |
I am now using spark-clickhouse-connector with pyspark, throw java.lang.ClassNotFoundException: xenon.clickhouse.Logging error, which makes me unable to test temporarily |
ok,I forgot, I will add it right away |
Please use |
Please take attention, I just merged 5dbc2fd, which changed the build command from |
30b115b
to
5246ee3
Compare
I'm using this file from the beginning, I'll try again |
LGTM, please click button "Ready for review" when you passed your local testing. |
My pyspark has another problem with jackson during clickhouse initialization. After I test it locally, I will click the ready button |
It seems that my JDBC version is too low cause throw an error |
The master branch code depends on the latest clickhouse client, you can choose to use one of the following jars
|
I don't know why it can't be tested locally, including using scala. I click ready first, you need to do a local test of the feature |
OK, let me merge it first and do manual test then. |
close #174