Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nodejs v20 #149

Closed
mshustov opened this issue Apr 12, 2023 · 3 comments
Closed

Add support for nodejs v20 #149

mshustov opened this issue Apr 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@mshustov
Copy link
Member

Initial Release: 2023-04-18. see https://github.com/nodejs/Release

@mshustov mshustov added the enhancement New feature or request label Apr 12, 2023
@slvrtrn
Copy link
Contributor

slvrtrn commented Apr 13, 2023

Let's combine it with #148

@olexiyb
Copy link
Contributor

olexiyb commented Apr 26, 2023

In our project we need to use latest node 19(20) as it gives very noticeable performance improvements.
When we started to use node 19 we started to capture Timeout errors on slow queries (the default clickhouse-js had to apply of 300 seconds).
I was able to track down this to incorrect value in socket.timeout was set to 3000
image
I suspect this is somehow related to nodejs/node#47137

After I have added

      request.once('socket', (socket) => {
        socket.setTimeout(this.config.request_timeout)
      })

The slow function started to work. This issue was reproducible on Mac M1 and alpine 3.17 (running in docker container)

@slvrtrn
Copy link
Contributor

slvrtrn commented Apr 26, 2023

@olexiyb, thanks for the contribution. Your fix is included in 0.0.15, which is available now.

@slvrtrn slvrtrn closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants