-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support custom socket factory #1420
Conversation
@zhicwu can you provide a complete code sample so we could add it to documentation |
There's test(example) as well as default implementation. Do we still need complete code sample? I didn't see that happening in the server repo :) Anyway, this was requested by @mayankvadariya, so let's wait for his comments before merging the PR. |
2f0aa9f
to
9270727
Compare
Kudos, SonarCloud Quality Gate passed! |
@mzitnik, can we merge this PR to close the issue? |
Thank you @zhicwu for this effort. It slipped as I had been busy lately. |
No problem. Let us know if it fits your need. |
Yes, I tested the changes locally. 🙌 Please let me know when can we release these changes. |
Summary
Support custom socket factory as requested in #1391.
Checklist
Delete items not relevant to your PR: