-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal of restructuring code (RFC) #570
Labels
Milestone
Comments
I am OK with all of this. |
I am totally Ok with all the proposed changes. |
While I do see a benefit in having clearer module structures, I think there is other stuff to do for 0.3.0 before trying to break things up this way, see Roadmap 2021 #537 |
Merged
Update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As the project grows, in order to better manage the code, expectations and dependencies, I hope we can re-organize the repository by creating multiple modules. With that, we no longer have to put all ideas into one single lib, trying to make it both a JDBC driver and Java client for ClickHouse. Instead, we'll follow JDBC specification in
clickhouse-jdbc
module for standard update/delete operation, synchronous execution, and escape syntax like{d '2020-02-17'}
(which is same astoDate('2021-02-17')
by the way) etc. On the other hand, we'll stick with the "clickhouse-way" when implementingclickhouse-client
module, so that it behaves like any other clickhouse clients.ru.yandex.clickhouse
->tech.clickhouse
clickhouse-java
later)I hope we can implement the new structure starting from
0.3.0
, but it's primarily about moving code fromsrc
toclickhouse-jdbc/src
and pile up code into other modules. This ensures we can produce binary compatible package in 0.3 series. And then, starting from0.4.0
, I hope we can optionally change package name and refactorclickhouse-jdbc
module by leveraging code fromclickhouse-client
module etc., which will introduce different binary packages.Please feel free to comment and I'll start to create PR if no concern.
The text was updated successfully, but these errors were encountered: