Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return result for insert #216

Closed
Shlomixg opened this issue Jul 4, 2023 · 1 comment · Fixed by #218
Closed

return result for insert #216

Shlomixg opened this issue Jul 4, 2023 · 1 comment · Fixed by #218
Assignees
@genzgd
Labels
enhancement New feature or request

Comments

@Shlomixg
Copy link

Shlomixg commented Jul 4, 2023

Is it possible to add results for methods command\insert\raw_insert with the amount of inserted rows?
@Shlomixg Shlomixg added the enhancement New feature or request label Jul 4, 2023
@genzgd
Copy link
Collaborator

genzgd commented Jul 5, 2023

We should definitely return what comes back in the X-ClickHouse-Summary header (although that may not be entirely accurate for things like materialized views, etc. -- see ClickHouse/ClickHouse#19274)

@genzgd genzgd self-assigned this Jul 5, 2023
@genzgd genzgd linked a pull request Jul 6, 2023 that will close this issue
0 6 5 release #218
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genzgd genzgd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0 6 5 release ClickHouse/clickhouse-connect
2 participants
@genzgd @Shlomixg