Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse-connect 0.5.2 is not considering proxy variables #114

Closed
Jishnu-Prakash-K opened this issue Feb 3, 2023 · 6 comments · Fixed by #115
Closed

clickhouse-connect 0.5.2 is not considering proxy variables #114

Jishnu-Prakash-K opened this issue Feb 3, 2023 · 6 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@Jishnu-Prakash-K
Copy link

clickhouse-connect 0.5.2 is not considering proxy variables. Added http_proxy, https_proxy. When I try with 0.1.5 version its able to connect. Could someone help with this?

Thanks in advance.

@genzgd
Copy link
Collaborator

genzgd commented Feb 3, 2023

I'm not sure what you mean by "added http_proxy, https_proxy" -- where did you add that? Also there is not a 0.1.5 release that I know of (and it would have been very old). Do you mean a different version? A different project?

In any case the current version doesn't support proxies without using a custom pool_mgr argument to the main get_client method. I will look at adding that support.

@genzgd genzgd added the enhancement New feature or request label Feb 3, 2023
@genzgd
Copy link
Collaborator

genzgd commented Feb 3, 2023

Are you talking about the environment variables HTTP_PROXY and HTTPS_PROXY?

@Jishnu-Prakash-K
Copy link
Author

Yeah, its an old version. I'm deploying it in kubernetes, added these variables in deployment file is what I meant.

Anyways version 0.2.7 also works with these variables.

@genzgd
Copy link
Collaborator

genzgd commented Feb 3, 2023

Thanks for the details. I'm working on a new release that should restore that functionality. It came "for free" with the requests library but that was removed and I didn't realize it was automatically handling those environment variables.

@Jishnu-Prakash-K
Copy link
Author

Thanks 👍🏼

@genzgd genzgd added bug Something isn't working and removed enhancement New feature or request labels Feb 4, 2023
@genzgd genzgd mentioned this issue Feb 4, 2023
2 tasks
@genzgd genzgd linked a pull request Feb 4, 2023 that will close this issue
2 tasks
@genzgd
Copy link
Collaborator

genzgd commented Feb 4, 2023

This should work with v0.5.7. Please re-open this issue if you have any problems. I've tested with a local http and https proxy but that doesn't guarantee it will work in all situations.

@genzgd genzgd closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants