-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches #8718
Merged
alexey-milovidov
merged 5 commits into
ClickHouse:master
from
Akazz:fixing_ternary_logic_for_batches
Jan 19, 2020
Merged
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches #8718
alexey-milovidov
merged 5 commits into
ClickHouse:master
from
Akazz:fixing_ternary_logic_for_batches
Jan 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added a commit
that referenced
this pull request
Jan 19, 2020
A followup to #8718: Simpler and faster code in logical functions
alesapin
pushed a commit
that referenced
this pull request
Jan 20, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches
alesapin
pushed a commit
that referenced
this pull request
Jan 20, 2020
A followup to #8718: Simpler and faster code in logical functions
alesapin
pushed a commit
that referenced
this pull request
Jan 20, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches
alesapin
pushed a commit
that referenced
this pull request
Jan 20, 2020
A followup to #8718: Simpler and faster code in logical functions
vitlibar
pushed a commit
that referenced
this pull request
Mar 25, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches (cherry picked from commit 36a7a40)
vitlibar
pushed a commit
that referenced
this pull request
Mar 25, 2020
Fixed ternary logic (OR/AND/XOR) calculation in multiple batches (cherry picked from commit 36a7a40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fixed up a bug in batched calculations of ternary logical OPs on multiple arguments (more than 10).
Detailed description (optional):
Functions
or
,and
might return incorrect results when called on more than 10 arguments while any of them beingNULL
Fixes #8469 that was addressed by @YiuRULE in #8511