Remove dependencies #208
Merged
Remove dependencies #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/remove_deps
branch
from
59b3266
to
f1d6e84
Compare
AlexisRenchon
approved these changes
Sep 2, 2024
Sbozzolo
force-pushed
the
gb/remove_deps
branch
from
f1d6e84
to
41790b8
Compare
ClimaParams should not depend on `Test` (no package should do so). `DocStringExtensions` was barely used, so I removed it (every package that uses ClimaParams inherits this dependency)
Sbozzolo
force-pushed
the
gb/remove_deps
branch
from
41790b8
to
769f189
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 2 2
Lines 134 134
=======================================
Hits 132 132
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClimaParams should not depend on
Test(no package should do so).DocStringExtensionswas barely used, so I removed it (every package that uses ClimaParams inherits this dependency)Closes #207