Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the purpose of AbstractTOMLDict? #194

Open
Sbozzolo opened this issue May 20, 2024 · 1 comment · May be fixed by #197
Open

What is the purpose of AbstractTOMLDict? #194

Sbozzolo opened this issue May 20, 2024 · 1 comment · May be fixed by #197
Assignees
@nefrathenrici

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented May 20, 2024 •
edited
Loading

The documentation reads:

"""
    AbstractTOMLDict{FT <: AbstractFloat}

Abstract parameter dict. One subtype:
 - [`ParamDict`](@ref)
"""

Indeed, there is only one subtype and the rest of the package is implemented around this type.

Maybe we can we remove this extra layer in the next breaking release?
@nefrathenrici
Copy link
Member

There used to be an additional subtype, but now this abstract type is unneeded. I can remove it soon.

@nefrathenrici nefrathenrici self-assigned this May 20, 2024
@nefrathenrici nefrathenrici linked a pull request May 31, 2024 that will close this issue
Remove AbstractTOMLDict #197
Open
@nefrathenrici nefrathenrici mentioned this issue May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nefrathenrici nefrathenrici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove AbstractTOMLDict CliMA/ClimaParams.jl
2 participants
@Sbozzolo @nefrathenrici