Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct doi for abifm desert dust params #167

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Feb 6, 2024

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7a8181) 98.49% compared to head (24d44ba) 98.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files           2        2           
  Lines         133      133           
=======================================
  Hits          131      131           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to change the parameter names? This will need to be a breaking release

@amylu00
Copy link
Member Author

amylu00 commented Feb 6, 2024

Do you need to change the parameter names? This will need to be a breaking release

Yes, but since it's only used in the gpu/perf/unit tests right now Anna and I were hoping to just do a version bump. Is that no good?

@nefrathenrici
Copy link
Member

That's fair enough! If they are only used in one place it should be fine.

@nefrathenrici nefrathenrici self-requested a review February 6, 2024 01:00
@trontrytel
Copy link
Member

But we still need to bump the patch version in the Project.toml file. version = "0.8.5" -> version = "0.8.6"

Those parameters are only used in CloudMicrophysics.jl tests. The packages that use CloudMicrophysics.jl don't use those functions. So I vote to do it as a patch release. We will fix the CM.jl tests quickly and noone will notce

@nefrathenrici
Copy link
Member

I will need a patch release for #165 as well so we could bundle the changes together.

@nefrathenrici nefrathenrici merged commit 7226a06 into main Feb 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants