Update default value for alpha_rayleigh_uh #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 2 2
Lines 133 133
=======================================
Hits 131 131
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
And could I make a patch release? Or do you want to update all other repos to the breaking release first? |
1 task
nefrathenrici
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
A patch release should be fine, but I will need to get ClimaAtmos #2562 merged in to use the new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want the default value for
alpha_rayleigh_uhto be zero. This was missed in ClimaAtmos PR#2021 I think. This PR also bumps patch version.To-do
Content