Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs built #161

Open
navidcy opened this issue Aug 22, 2024 · 2 comments · May be fixed by #156
Open

Docs built #161

navidcy opened this issue Aug 22, 2024 · 2 comments · May be fixed by #156
Labels
documentation Improvements or additions to documentation

Comments

@navidcy
Copy link
Collaborator

navidcy commented Aug 22, 2024

At the moment the docs are build with GitHub actions and also via buildkite-ci for examples.

But we can't have two ways of building the docs. When GitHub actions build docs without the examples then it pushes it and it overwrites the other docs. However the buildkite-CI only runs when the PR has a particular label...

The workflow is not robust and results in situations like the one described in #157...

@navidcy navidcy added the documentation Improvements or additions to documentation label Aug 22, 2024
@simone-silvestri
Copy link
Collaborator

I thought that #156 would solve this issue by nuking the GitHub actions build. Note that the docs are build always on main. The steps in buildkite read:

steps:
  - command: "buildkite-agent pipeline upload .buildkite/examples_build.yml "
    label: ":pipeline:"
    if: "build.pull_request.labels includes \"Run examples\" || build.branch == \"main\"" 
    agents:
      queue: new-central

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 26, 2024

Yes, #156 should resolve this. Just wanted to document it for future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants