Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize slugs to FI, SV, ENG #141

Open
anmipa opened this issue Nov 14, 2018 · 6 comments
Open

Localize slugs to FI, SV, ENG #141

anmipa opened this issue Nov 14, 2018 · 6 comments
Assignees
@tuomas777 @igordavydsson
Labels
Priority: Low

Comments

@anmipa
Copy link

anmipa commented Nov 14, 2018 •
edited by janimattiellonen
Loading

This includes index (/mydata). Landing page has these translations for /mydata at the moment:

  • Omat tietosi
  • Dina uppgifter
  • My data
@anmipa
Copy link
Author

anmipa commented Nov 14, 2018

Note to future: this might be complicated with Wagtail, url translations have to be checked against Wagtail (landing page) translations.

That or everything goes to hell.

@janimattiellonen
Copy link
Contributor

The url needs to contain the selected language.

https://omahelsinki.test.hel.ninja/en/mydata
https://omahelsinki.test.hel.ninja/fi/tietoni

@janimattiellonen janimattiellonen changed the title Mydata: add url routes for tabs and localize slugs to FI, SV, ENG Loocalize slugs to FI, SV, ENG Nov 26, 2018
@janimattiellonen
Copy link
Contributor

janimattiellonen commented Nov 26, 2018 •
edited
Loading

Do this first: #169

@anmipa anmipa changed the title Loocalize slugs to FI, SV, ENG Localize slugs to FI, SV, ENG Nov 26, 2018
@igordavydsson igordavydsson self-assigned this Nov 28, 2018
@janimattiellonen
Copy link
Contributor

I would use

  • Omat tietoni
  • Mina uppgifter
  • My data

Instead of Sinun.., Dina..., Your...

@janimattiellonen
Copy link
Contributor

janimattiellonen commented Dec 11, 2018 •
edited
Loading

Currently we are going with these:

Omat tiedot: /fi/omat-tiedot
Mina uppgifter: /sv/mina-uppgifter
My data: /en/my-data

@tuomas777 tuomas777 self-assigned this Dec 11, 2018
@tuomas777
Copy link
Contributor

Wagtail parts of this are implemented in translated-urls branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuomas777 tuomas777

@igordavydsson igordavydsson

Labels
Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janimattiellonen @tuomas777 @anmipa @igordavydsson