Bug: Cannot read clipboard image on MacOS for screenshots taken by certain apps

[HuakunShen]

The problem | 问题描述

Issue first mentioned in CrossCopy/tauri-plugin-clipboard#21 by @Tester-957

Screenshots taken with Feishu/Lark can neither be detected nor read by clipboard-rs, while regular screenshots and screenshots taken by other apps like WeChat could be detected.

By running the sample code we can see that ctx.get_image() doesn't return Err, but the resulting image has a size of (0, 0)

Release version | 版本

0.1.5

Operating system | 操作系统

MacOS

Logs | 日志

No response

[HuakunShen]

Bug located

Here is the available formats for a regular screenshot: ["public.png", "Apple PNG pasteboard type", "public.tiff", "NeXT TIFF v4.0 pasteboard type"]

Here is the available formats for a Feishu screenshot ["public.tiff", "NeXT TIFF v4.0 pasteboard type"]

Screenshot taken with Feishu somehow doesn't support PNG format, and only PNG is considered in the code

clipboard-rs/src/platform/macos.rs

Line 279 in 7b23a6f

let ns_data = self.clipboard.dataForType(NSPasteboardTypePNG);

Solution

clipboard.dataForType(NSPasteboardTypeTIFF) will return screenshots from Feishu.
TIFF is supported by both regular screenshot and Feishu screenshot (verified), so you could simply replace NSPasteboardTypePNG with NSPasteboardTypeTIFF
However, it might be prudent to handle both TIFF and PNG formats for has() and get_image(), ensuring compatibility across different scenarios. Supporting both formats is a safer approach.

[HuakunShen]

PR opened here by @ChurchTao #16

Fixed by adding a check on the value of png and tiff returned. If there is no data, Err is returned.

[ChurchTao]

next version will be ok～