Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the .scss file to latest Sass #964

Closed
creativeDM opened this issue Jul 20, 2021 · 3 comments
Closed

Update the .scss file to latest Sass #964

creativeDM opened this issue Jul 20, 2021 · 3 comments
Labels

Comments

@creativeDM
Copy link

Hello Team Choices.
I am getting the error from sass when i compiling the imported choices.scss with my style.scss file

Here is what sass says 🙄

`DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$choices-button-offset, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

129 │ margin-right: -$choices-button-offset/2;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^

node_modules\choices.js\src\styles\choices.scss 129:19 @import
src\scss\style.scss 15:9`

Please Update the scss file with latest sass version. Its taking the time during development.

Anyway - Great Plugin and loved to used it 👍

Thanks for making such a beautiful plugin.

@creativeDM creativeDM added the bug label Jul 20, 2021
@leereichardt
Copy link

PR already created for this found here #963

@hans2103
Copy link
Contributor

hans2103 commented Dec 13, 2021

instead of using math.div I suggest to use multiplier * instead. No introduction of new technology and using already used technology instead.
See #976

@mtriff
Copy link
Member

mtriff commented Dec 21, 2021

Resolved in v9.1.0

@mtriff mtriff closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants