Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove malicious polyfill.io usage #1161

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

alanhamlett
Copy link
Contributor

Polyfill.io is redirecting to malicious websites. This PR removes the optional and unnecessary polyfill.io usage.

@hotwebmatter
Copy link

I'm not a maintainer, but this looks good to me.

Merging this would also resolve #1162

There's some urgency here; without this patch, the Choices-js library functions as a vector for malware. 👾

Copy link

@mbomb007 mbomb007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@mbomb007
Copy link

I will also note that the website linked on the repo, choices-js[dot]github[dot]io/Choices/ contains the malicious CDN until this is fixed.

@mbomb007
Copy link

The repo doesn't appear to be maintained anymore. Nothing has been committed or merged in two years, neither on this repo, nor in any other repo by the main two maintainers.

Can someone contact a maintainer or someone with access to merge commits?

@icf-chartmann
Copy link

icf-chartmann commented Jul 1, 2024

I'm emailing the maintainer at matt@modeldba.com

Hi Matt,

There is a PR (#1161) to replace the newly malicious polyfill.io dependency for the Choices library. The PR has been reviewed and approved but requires the maintainer to merge.
There are hundreds of thousands of Drupal websites using Webforms that rely on this plugin.
Please review and merge.
I will help find a new maintainer if you’re interested, but for now, please take action on this critical security issue.

Sincerely,
Carey Hartmann and the Drupal Community

@dontWatchMeCode dontWatchMeCode mentioned this pull request Jul 11, 2024
10 tasks
Xon added a commit to Xon/Choices.js that referenced this pull request Jul 29, 2024
Xon added a commit that referenced this pull request Aug 5, 2024
@Xon Xon merged commit c2f1b82 into Choices-js:master Aug 5, 2024
@Xon Xon mentioned this pull request Aug 6, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants