Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oEmbed protocol #94

Closed
Chocobozzz opened this issue Oct 9, 2017 · 5 comments
Closed

Implement oEmbed protocol #94

Chocobozzz opened this issue Oct 9, 2017 · 5 comments

Comments

@Chocobozzz
Copy link
Owner

Spec: https://oembed.com/

@Chocobozzz
Copy link
Owner Author

Implemented: d8755ee

But most consumers use whitelist to accept or not HTML from OEmbed servers (for security reasons), so this does not really work. Since PeerTube can be installed under any domain, I don't think there is an easy way to have the player embedded on social networks (even on Diaspora, Mastodon...).

@tcitworld
Copy link
Collaborator

There's the OpenGraph og:video metadata that's missing and may be required to embeed videos on some websites.

@Chocobozzz Chocobozzz removed their assignment Oct 26, 2017
@Chocobozzz
Copy link
Owner Author

Thanks @tcitworld -> 7ff7802

@PeterAlfonsLoch
Copy link

PeterAlfonsLoch commented Apr 23, 2020

The og:video tag is missing and should have a url to the file, not the embed url.

If you want to use the og:video:url and og:video:secure_url then it's the same thing it should be a url to the file and not the embed link.

Example: <meta property="og:video" content="http://example.com/bond/trailer.swf" />
source: https://ogp.me/#metadata

@Chocobozzz
Copy link
Owner Author

@PeterAlfonsLoch It's what dailymotion, youtube or vimeo already do. I don't say they are doing it correctly, but we need to keep consistency with existing video platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants