Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup Process Changes Break Existing Plugins #5375

Closed
own3mall opened this issue Oct 24, 2022 · 2 comments
Closed

Signup Process Changes Break Existing Plugins #5375

own3mall opened this issue Oct 24, 2022 · 2 comments

Comments

@own3mall
Copy link

own3mall commented Oct 24, 2022

Describe the current behavior

I'm not sure when this changed, but since user signup registration process has changed, existing plugins such as Recaptcha V2 no longer work due to DOM changes.

#1721

Steps to reproduce

  1. Install Recaptcha V2 plugin. (https://framagit.org/rigelk/peertube-plugin-recaptcha)
  2. Go through new user signup / registration process on updated PeerTube instance with recaptcha plugin enabled. No recaptcha is shown during the signup process due to a console error which states that the plugin script is unable to find a form element which no longer exists when scope of signup is first loaded.

Describe the expected behavior

Old plugins continue to work.

@Chocobozzz
Copy link
Owner

Hello,

We don't provide DOM compatibility for plugins. It's the reason why we added the concept of HTML placeholders: https://docs.joinpeertube.org/contribute-plugins?id=html-placeholder-elements

Please create the issue on the plugin owner repository

@own3mall
Copy link
Author

@Chocobozzz Going through the documentation, it doesn't seem there's any infrastructure there anymore for a plugin like this (add recaptcha to sign up form) to hook into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants