Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dependencies should be dev-only #55

Closed
zarsky-broad opened this issue Sep 8, 2019 · 1 comment
Closed

Some dependencies should be dev-only #55

zarsky-broad opened this issue Sep 8, 2019 · 1 comment

Comments

@zarsky-broad
Copy link

When trying to run my react-scripts based app after upgrading this package to its latest version, I get a warning:

The react-scripts package provided by Create React App requires a dependency:

  "babel-loader": "8.0.5"

Looking at the changes, this commit appears to have moved a number of dependencies from dev to normal when upgrading them. Leaving this as-it would mean that any react-scripts app that uses a different version of that package would be unable to depend on this one.

@davidnguyen11
Copy link
Contributor

Hi @zarsky-broad

Thank you very much for your report. I published version 1.3.1. Can you try again? if it's ok pls close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants