Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header path incorrect when linking to outside msdfgen #103

Open
robindegen opened this issue Jul 7, 2024 · 2 comments
Open

Header path incorrect when linking to outside msdfgen #103

robindegen opened this issue Jul 7, 2024 · 2 comments

Comments

@robindegen
Copy link

When installing msdfgen (and packaging it); all headers are in a subdirectory; for example:
include/msdfgen/msdfgen.h

However; msdf-atlas-gen assumes they're in the root:
#include <msdfgen.h>

This causes problems when trying to neatly package the libraries into tools like Conan. Ofcourse I can move headers around before packaging but that's a little odd.

@Chlumsky
Copy link
Owner

Chlumsky commented Jul 7, 2024

I think it should just be added to include path rather than moving the files.

@robindegen
Copy link
Author

That's how I worked around it yes. But that doesn't really work in all circumstances since its non-standard. If you cmake install onto the system directly and then use a findscript; it still wouldn't be able to find them; especially if you throw something like autotools into the mix.

I wouldn't suggest moving the files though; that would just cause clutter. I would suggest to include them as #include <msdfgen/msdfgen.h> in atlas-gen as they are deployed that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants