Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fee amount is not listed correctly in wallet #15406

Open
neurosis69 opened this issue May 31, 2023 · 6 comments
Open

[Bug] Fee amount is not listed correctly in wallet #15406

neurosis69 opened this issue May 31, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@neurosis69
Copy link
Contributor

neurosis69 commented May 31, 2023

What happened?

For chia rpc wallet get_farmed_amount the fees are calculated on the fly and listed correctly.

But for other commands like

  • chia rpc wallet get_transactions '{"wallet_id": 1}' or
  • chia wallet get_transactions
    the fee_amount is always zero, but shown as part of the actual amount.

This is already the case in the wallet db table transaction_record:

sqlite> select chia_amount_int(amount) as amount, chia_amount_int(fee_amount) fee_amount from transaction_record where wallet_id=1 and type=3;
amount|fee_amount
250000000000|0
250000000000|0
250000300020|0
250000000000|0
250000000000|0

I've found the following code lines where the fee_amount is hard coded to 0 when preparing the transaction record for the insert:

https://github.com/Chia-Network/chia-blockchain/blob/d36703337a9164ad36ab15772e85ae2cf7ebfc34/chia/wallet/wallet_state_manager.py#LL1158-L1158
https://github.com/Chia-Network/chia-blockchain/blob/d36703337a9164ad36ab15772e85ae2cf7ebfc34/chia/wallet/wallet_state_manager.py#LL1175-L1175
https://github.com/Chia-Network/chia-blockchain/blob/d36703337a9164ad36ab15772e85ae2cf7ebfc34/chia/wallet/wallet_state_manager.py#LL1219-L1219
https://github.com/Chia-Network/chia-blockchain/blob/d36703337a9164ad36ab15772e85ae2cf7ebfc34/chia/wallet/wallet_state_manager.py#LL1501-L1501

Version

1.8.1

What platform are you using?

Linux

What ui mode are you using?

CLI

Relevant log output

No response

@neurosis69 neurosis69 added the bug Something isn't working label May 31, 2023
@github-actions
Copy link
Contributor

This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.

@github-actions github-actions bot added the stale-issue flagged as stale and will be closed in 7 days if not updated label Jun 14, 2023
@neurosis69
Copy link
Contributor Author

Please keep this issue open.

@github-actions github-actions bot removed the stale-issue flagged as stale and will be closed in 7 days if not updated label Jun 15, 2023
@neurosis69
Copy link
Contributor Author

Post to keep this issue open

@github-actions
Copy link
Contributor

This issue has not been updated in 14 days and is now flagged as stale. If this issue is still affecting you and in need of further review, please comment on it with an update to keep it from auto closing in 7 days.

@github-actions github-actions bot added the stale-issue flagged as stale and will be closed in 7 days if not updated label Jul 11, 2023
@neurosis69
Copy link
Contributor Author

Keep issue open.

@github-actions github-actions bot removed the stale-issue flagged as stale and will be closed in 7 days if not updated label Jul 12, 2023
@neurosis69
Copy link
Contributor Author

Post to keep this issue open

@emlowe emlowe assigned arvidn and unassigned trepca Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants