From c9d460ccbd509123398655916b51790845f2d320 Mon Sep 17 00:00:00 2001 From: ChengJinbao Date: Mon, 18 Jul 2022 10:29:38 -0700 Subject: [PATCH] add definition for state attribute of system.network.connections (#2663) --- CHANGELOG.md | 2 ++ specification/metrics/semantic_conventions/system-metrics.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 16bbbb2..1fcecfd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -57,6 +57,8 @@ release. ([#2594](https://github.com/open-telemetry/opentelemetry-specification/pull/2594)) - Add semantic conventions for JVM buffer pool usage ([#2650](https://github.com/open-telemetry/opentelemetry-specification/pull/2650)). +- Improve the definition of `state` attribute for metric `system.network.connections` + ([#2663](https://github.com/open-telemetry/opentelemetry-specification/pull/2663)) ### Compatibility diff --git a/specification/metrics/semantic_conventions/system-metrics.md b/specification/metrics/semantic_conventions/system-metrics.md index f9f6cb7..685e047 100644 --- a/specification/metrics/semantic_conventions/system-metrics.md +++ b/specification/metrics/semantic_conventions/system-metrics.md @@ -148,7 +148,7 @@ perf counter (similar for Writes) | system.network.io.receive | Bytes received | By | Counter | Int64 | device | (identifier) | | system.network.connections | | {connections} | UpDownCounter | Int64 | device | (identifier) | | | | | | | protocol | tcp, udp, [etc.](https://en.wikipedia.org/wiki/Transport_layer#Protocols) | -| | | | | | state | [e.g. for tcp](https://en.wikipedia.org/wiki/Transmission_Control_Protocol#Protocol_operation) | +| | | | | | state | If specified, SHOULD be one of: close, close_wait, closing, delete, established, fin_wait_1, fin_wait_2, last_ack, listen, syn_recv, syn_sent, time_wait. A stateless protocol MUST NOT set this attribute. | 1 Measured as: